nrf_security: CRACEN: Let ecdsa sign/verify digest without hash #24017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog-entry-required
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: b69a9d8a01281b903358ea907397d4b460276c73 more detailssdk-nrf:
Github labels
List of changed files detected by CI (2)Outputs:ToolchainVersion: c5be9c56c7 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
tomi-font
requested changes
Aug 15, 2025
Comment on lines
409
to
416
| psa_status = hash_get_algo(alg, &hash_algorithm_ptr); | ||
| if (psa_status != PSA_SUCCESS) { | ||
| return psa_status; | ||
| } |
There was a problem hiding this comment.
Suggested change
| psa_status = hash_get_algo(alg, &hash_algorithm_ptr); | |
| if (psa_status != PSA_SUCCESS) { | |
| return psa_status; | |
| } |
degjorva
force-pushed
the
fix-ecdsa-hash
branch
3 times, most recently
from
0e2588c to
a6311f6
Compare
degjorva
changed the title
ECDSA_SIGN/VERIFY_HASH should not require a hash algorithm to be present Updated so it is not required. Signed-off-by: Dag Erik Gjørvad <[email protected]>
degjorva
force-pushed
the
fix-ecdsa-hash
branch
from
a6311f6 to
b69a9d8
Compare
degjorva
removed
the
changelog-entry-required
Vge0rge
approved these changes
Aug 21, 2025
tomi-font
approved these changes
Aug 22, 2025
| status = hash_get_algo(alg, &hashalgpointer); | ||
| if (status != PSA_SUCCESS) { | ||
| return status; | ||
| } | ||
| if (is_message) { | ||
| status = cracen_ecdsa_sign_message_deterministic( | ||
| &privkey, hashalgpointer, ecurve, input, input_length, signature); |
There was a problem hiding this comment.
cracen_ecdsa_sign_digest_deterministic() below still takes hashalgpointer, which I guess means requires hash support even though is_message is false?
There was a problem hiding this comment.
deterministic_ecdsa needs a hash function to work, so you can't run without it even if it is a sign_hash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ECDSA_SIGN/VERIFY_HASH should not require a hash algorithm to be present. Updated so only sign message requires one.